Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable prefetch dependencies in Konflux #1323

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

ernesgonzalez33
Copy link
Contributor

Needs #1322 merged before

@ernesgonzalez33 ernesgonzalez33 changed the title chore: enable hermetic builds in Konflux chore: enable prefetch dependencies in Konflux Sep 10, 2024
@ernesgonzalez33
Copy link
Contributor Author

/retest

1 similar comment
@ernesgonzalez33
Copy link
Contributor Author

/retest

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.50%. Comparing base (13484d0) to head (bbcf523).
Report is 43 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1323      +/-   ##
==========================================
- Coverage   36.81%   36.50%   -0.31%     
==========================================
  Files         158      159       +1     
  Lines        2548     2586      +38     
  Branches      599      605       +6     
==========================================
+ Hits          938      944       +6     
- Misses       1428     1460      +32     
  Partials      182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaacov
Copy link
Member

yaacov commented Sep 19, 2024

Needs #1322 merged before

@ernesgonzalez33 hi, #1322 merged upstream

@ernesgonzalez33
Copy link
Contributor Author

I'll rebase and let you know!

Signed-off-by: Ernesto González <ergonzal@redhat.com>
Signed-off-by: Ernesto González <ergonzal@redhat.com>
@ernesgonzalez33 ernesgonzalez33 marked this pull request as ready for review September 19, 2024 10:56
Copy link

sonarcloud bot commented Sep 19, 2024

@ernesgonzalez33
Copy link
Contributor Author

/retest

@ernesgonzalez33
Copy link
Contributor Author

@yaacov @mnecas I know that the test is failing, but this is due to an architectural decision on Konflux to test components inside an app together. So it is testing this specific PR at the same time as the main branch of the must-gather repo (which was failing), so until we don't merge these two working, it will keep failing. So my suggestion is to merge this PR and then test it with the #1329

@yaacov yaacov merged commit 8479611 into kubev2v:main Sep 19, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants